Conversation
juliusknorr
left a comment
There was a problem hiding this comment.
Small comments, otherwise this looks good and works (with nextcloud/server#43005 for testing)
src/components/Assistant.vue
Outdated
| computed: { | ||
| showAssistant() { | ||
| return !this.$isRichWorkspace && !this.$isPublic && window?.OCA?.TPAssistant?.openAssistantForm | ||
| return !this.$isRichWorkspace && !this.$isPublic && window?.OCA?.TpAssistant?.openAssistantForm |
There was a problem hiding this comment.
@julien-nc Was there a casing change in the API here? Is it bound to a Nextcloud release?
There was a problem hiding this comment.
All right, last release has it upper case and main branch as well (just some intermediate state before nextcloud/assistant#27 had the p lower case) so @luka-nextcloud We should revert this change to be TPAssistant
There was a problem hiding this comment.
Sorry for the late answer. This was and will stay OCA.TPAssistant.
|
@luka-nextcloud Could you also take the time to add cypress coverage for this part? We can enable the testing app for this in the github action. |
|
Tested and works function wise 👍 @julien-nc I noticed some odd behaviour with nextcloud/server#43005 where having multiple text processing providers enabled leads to the async one alwas being used in the assistant modal. I haven't touched any configuration, though the AI settings show the synchronous one as a default: 
|
6915ba4 to
cd4d726
Compare
I've added it, please check. |
| php /var/www/html/occ user:add --password-from-env user2 | ||
| php /var/www/html/occ app:enable viewer | ||
| php /var/www/html/occ app:enable text | ||
| php /var/www/html/occ app:enable assistant |
There was a problem hiding this comment.
I think this was for some way of running isolated cypress tests locally, but never used that script myself. @max-nextcloud Do you happen to know if we still make use of that?
There was a problem hiding this comment.
Was just for local tests, but nowadays we could use @nextcloud/cypress/docker which also works locally :)
cd4d726 to
ec0a368
Compare
ec0a368 to
750084a
Compare
750084a to
4eccbde
Compare
|
@luka-nextcloud Could you check why the cypress tests fail there? |
@juliushaertl Thanks, I'll check that. Maybe there's a mismatch between the default value displayed in the settings frontend and the actual default selected provider when creating a task. |
Signed-off-by: Luka Trovic <[email protected]>
Signed-off-by: Luka Trovic <[email protected]>
4eccbde to
10ebf2e
Compare
Signed-off-by: Julius Härtl <[email protected]>
|
Pushed a small adjustment for the github action that should make cypress pass. |
📝 Summary
🖼️ Screenshots
🚧 TODO
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)