perf: Use getFirstNodeById and pass userId for our internal helper to avoid fetching mountpoints#5933
Merged
juliusknorr merged 1 commit intomainfrom Jun 21, 2024
Merged
Conversation
… avoid fetching mountpoints Signed-off-by: Julius Härtl <[email protected]>
max-nextcloud
approved these changes
Jun 21, 2024
Collaborator
max-nextcloud
left a comment
There was a problem hiding this comment.
looks good to me.
This was referenced Oct 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we don't care which node we get by id we can use the optimized/cached getFirstNodeById instead. In addition I noticed we can skip getting mounts for a given file id to determine the user if we pass it upfront to our internal helper to get the file with the highest permission.