[stable29] fix: Reset session if file rename changes mimetype from/to markdown#6347
Merged
juliusknorr merged 1 commit intostable29from Sep 13, 2024
Merged
[stable29] fix: Reset session if file rename changes mimetype from/to markdown#6347juliusknorr merged 1 commit intostable29from
juliusknorr merged 1 commit intostable29from
Conversation
mejo-
approved these changes
Sep 11, 2024
742747b to
6506a80
Compare
juliusknorr
requested changes
Sep 13, 2024
| public function __construct(AttachmentService $attachmentService) { | ||
| $this->attachmentService = $attachmentService; | ||
| public function __construct( | ||
| private readonly AttachmentService $attachmentService, |
Member
There was a problem hiding this comment.
readonly is not available for PHP 8.0
For the event target file, we cannot use `getMimetype()` or `getExtension()` as it's a node of type `NonExistingFile`. Fixes: #5736 Signed-off-by: Jonas <[email protected]>
6506a80 to
f694878
Compare
juliusknorr
approved these changes
Sep 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #6345