fix: Load focus trap extension in markdown content editor#6823
Merged
juliusknorr merged 1 commit intomainfrom Jan 13, 2025
Merged
fix: Load focus trap extension in markdown content editor#6823juliusknorr merged 1 commit intomainfrom
juliusknorr merged 1 commit intomainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6823 +/- ##
==========================================
+ Coverage 46.56% 46.58% +0.02%
==========================================
Files 748 733 -15
Lines 34311 34292 -19
Branches 1242 1227 -15
==========================================
Hits 15976 15976
+ Misses 17713 17709 -4
+ Partials 622 607 -15 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Julius Knorr <[email protected]>
d15759b to
b746fcf
Compare
grnd-alt
approved these changes
Jan 13, 2025
Member
Author
|
/backport to stable30 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix nextcloud/deck#6550
We should make sure to also load the focus trap plugin when using the markdown content editor e.g. in deck as otherwise using the tab key will just focus on the next element instead of triggering editor functionality first.