fix(files): add tiptap-text-direction extension to support RTL#6874
fix(files): add tiptap-text-direction extension to support RTL#6874JuliaKirschenheuter merged 1 commit intomainfrom
tiptap-text-direction extension to support RTL#6874Conversation
max-nextcloud
left a comment
There was a problem hiding this comment.
The test failures look related as now dir="ltr" is include in some of the html output of the unit tests. I think you can just adjust the expectation to match the actual outcome - and we get a test for this extension for free.
Other than that and the linter fix this looks great. Thanks for looking into it!
Would be nice if we could backport it as I think it really fixes a UX bug for rtl and mixed language use.
7511bea to
6c1bcf3
Compare
|
/backport to stable28 |
|
/backport to stable29 |
|
/backport to stable30 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6874 +/- ##
==========================================
+ Coverage 37.85% 37.98% +0.12%
==========================================
Files 750 735 -15
Lines 42637 42504 -133
Branches 1273 1258 -15
==========================================
+ Hits 16142 16146 +4
+ Misses 25873 25751 -122
+ Partials 622 607 -15 ☔ View full report in Codecov by Sentry. |
juliusknorr
left a comment
There was a problem hiding this comment.
Change looks sane, @max-nextcloud could you also have a quick look/approval before merging?
max-nextcloud
left a comment
There was a problem hiding this comment.
Code changes look good. Thanks for taking care of this.
🚀
|
Not sure what happened with the cypress tests. Restarted them. |
|
This cypress test fails fairly reliably:
Looks like the extension might change the document to inserte the |
Thank you @max-nextcloud a lot! Does it mean, i should specify tests more clearly? |
|
yep, able to reproduce a problem ;(( |
Signed-off-by: julia.kirschenheuter <[email protected]>
afbf2ee to
0f02d1f
Compare
should be solved now after amirhhashemi/tiptap-text-direction#19 |
📝 Summary
Now it is possible to detect RTL writing style for languages, which requires RTL. Using https://github.com/amirhhashemi/tiptap-text-direction extension. This version works for:
🖼️ Screenshots
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)