fix(SaveService): Don't save if yjs reports pendingStructs#7704
Draft
fix(SaveService): Don't save if yjs reports pendingStructs#7704
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7704 +/- ##
==========================================
+ Coverage 59.52% 59.55% +0.03%
==========================================
Files 503 503
Lines 39118 39150 +32
Branches 1130 1130
==========================================
+ Hits 23285 23317 +32
Misses 15725 15725
Partials 108 108 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
19a67fe to
d437604
Compare
Yjs pendingStructs most likely mean that the local yjs document state is missing a step. So let's not autosave such an inconstent state to the server. Signed-off-by: Jonas <[email protected]>
d437604 to
28ee3e7
Compare
4 tasks
Collaborator
|
Waiting for the outcome of our attempts to prevent out of sync state and thus pending structs in the first place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yjs pendingStructs mean that the local yjs document state is missing a step. So let's not allow to save such an inconstent state to the server.
Screenshot
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)