Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2070 +/- ##
==========================================
- Coverage 46.38% 45.85% -0.54%
==========================================
Files 15 15
Lines 429 434 +5
Branches 82 83 +1
==========================================
Hits 199 199
- Misses 202 207 +5
Partials 28 28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
grnd-alt
commented
Oct 28, 2025
| path?: string | ||
| }>(), { | ||
| allowPickDirectory: false, | ||
| allowCreateNew: false, |
Contributor
Author
There was a problem hiding this comment.
it feels like this default would be better off to be true but allowPickDirectory has a default of false and they maybe should be consistent?!
Contributor
There was a problem hiding this comment.
Maybe just use noMenu with default false
Contributor
|
I think it would be good to call the pop |
Signed-off-by: grnd-alt <[email protected]>
3dc0665 to
af199ae
Compare
susnux
approved these changes
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1893
required for: nextcloud/server#54234