Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
2c0461e to
7de9b5f
Compare
|
It looks really good, some points:
|
I think that that would be too big for most purposes. I already made it slightly bigger than what we currently have. Also we're aiming at WCAG level 2 for most of our UI elements.
I would do this in separate components in order to have smaller and easier to maintain components. Once we have them we can create a "meta"
Sounds good :)
These are already bound because all the attrs are inherited by the inner html
Sounds good :) |
|
What about adding this label icon from within the textfield component, as a slot for example? |
That would make sense and I would be happy with that too: What I see as patterns are: personal page
theming section
inline textfield
|
|
nickvergessen
left a comment
There was a problem hiding this comment.
In case of passwords the clear button should be replaced with an Eye-con to show the password instead of ***** ?
Or not part of v1 of the component?
Co-authored-by: Carl Schwan <[email protected]> Signed-off-by: Marco <[email protected]>
Co-authored-by: Joas Schilling <[email protected]> Signed-off-by: Marco <[email protected]>
Co-authored-by: Joas Schilling <[email protected]> Signed-off-by: Marco <[email protected]>
Co-authored-by: Joas Schilling <[email protected]> Signed-off-by: Marco <[email protected]>
Signed-off-by: Marco Ambrosini <[email protected]>
Abstracts some logic into a more general purpose InputVue component and build the TextField component on top of that. Signed-off-by: Marco Ambrosini <[email protected]>
Signed-off-by: Marco Ambrosini <[email protected]>
Signed-off-by: Marco Ambrosini <[email protected]>
|
/backport to stable5 |
Co-authored-by: Joas Schilling <[email protected]> Signed-off-by: Marco <[email protected]>
e589eec to
f1be9a1
Compare




fixes #2866
Screen.Recording.2022-07-27.at.11.44.52.mov