fix(NcRichContenteditable): remove value linkify#6372
Merged
Conversation
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Contributor
|
We're not using that component in text/collextives |
nickvergessen
approved these changes
Jan 13, 2025
Contributor
|
That seemed like a good feature, why are we removing this now? |
Contributor
Probably because there is no usecase and not documented? |
Contributor
|
We're actually using this mixin to render description (as per original PR): Maybe make it optional, so that NcRichContentEditable doesn't render links inside of editable content, but presenting components do? Or we'll just migrate to NcRichText here 👀 |
Antreesy
approved these changes
Feb 12, 2025
Contributor
Antreesy
left a comment
There was a problem hiding this comment.
Non-blocking for Talk anymore
juliusknorr
approved these changes
Feb 12, 2025
Contributor
|
/backport to next |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
NcRichContenteditable has a hidden feature: when a content is set outside (not inputted⚠️ ), it's linkified.
@juliusknorr @mejo- Could you confirm you don't rely on this behavior in text/collectives?
🖼️ Screenshots
🏁 Checklist
nextrequested with a Vue 3 upgrade