fix(NcRich*): style fixes and RTL support#6474
Merged
Conversation
- we did not support custom classes since component was merged, so should not be breaking Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
- closer to native ~40px from user agent Signed-off-by: Maksim Sukharev <[email protected]>
susnux
reviewed
Jan 31, 2025
| position: absolute; | ||
| left: -10000px; | ||
| /* stylelint-disable csstools/use-logical */ /* upstream logic */ | ||
| left: -100vw; |
Contributor
There was a problem hiding this comment.
why is this needed? Cant you just use inset-inline-start?
Contributor
Author
There was a problem hiding this comment.
.tribute-container applies computed styles to position itself with left.
With RTL it's going to be left: <calculated>px; right: -100vw;, so it will be out of screen
DorraJaouad
approved these changes
Jan 31, 2025
Contributor
DorraJaouad
left a comment
There was a problem hiding this comment.
Tested with Arabic, no issues.
Contributor
Author
|
/backport to next |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
markdownCssClassesand styles for it🖼️ Screenshots
🏁 Checklist
nextrequested with a Vue 3 upgrade