Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(NcActions): Remove on mousemove listener for auto focus elements#6475

Merged
raimund-schluessler merged 1 commit intomasterfrom
fix/actions-on-scroll
Jan 31, 2025
Merged

fix(NcActions): Remove on mousemove listener for auto focus elements#6475
raimund-schluessler merged 1 commit intomasterfrom
fix/actions-on-scroll

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Jan 30, 2025

☑️ Resolves

  1. This causes issues with the native datetime picker on Safari as the mouse move is also considered outside when hovering a picker popover that overlays other actions.
  2. In general this is very unexpected behavior, e.g. click on a text input, type something, move the mouse and keep typing. You expect to write to the same input but the focus is changed to a different while typing.

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@susnux susnux added bug Something isn't working 3. to review Waiting for reviews feature: actions Related to the actions components browser: Safari labels Jan 30, 2025
@susnux susnux added this to the 8.23.0 milestone Jan 30, 2025
ShGKme

This comment was marked as resolved.

@ShGKme
Copy link
Contributor

ShGKme commented Jan 30, 2025

1. This causes issues with the native datetime picker on Safari as the
   mouse move is also considered outside when hovering a picker popover
   that overlays other actions.
2. In general this is very unexpected behavior, e.g. click on a text
   input, type something, move the mouse and keep typing. You expect to
   write to the same input but the focus is changed to a different while
   typing.

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux force-pushed the fix/actions-on-scroll branch from 8e17f13 to 1737468 Compare January 30, 2025 15:55
@susnux susnux requested a review from ShGKme January 30, 2025 15:55
@susnux

This comment was marked as resolved.

Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 💃

Copy link
Contributor

@raimund-schluessler raimund-schluessler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks a lot!

Supersedes #5014 and also closes #5991.

@raimund-schluessler raimund-schluessler linked an issue Jan 31, 2025 that may be closed by this pull request
@raimund-schluessler raimund-schluessler merged commit 85a7c64 into master Jan 31, 2025
23 checks passed
@raimund-schluessler raimund-schluessler deleted the fix/actions-on-scroll branch January 31, 2025 12:22
@raimund-schluessler
Copy link
Contributor

/backport to next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews browser: Safari bug Something isn't working feature: actions Related to the actions components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NcDateTimePickerNative: Dialog Appearance Issue in Safari NcActionInput: Input loses focus when moving mouse

3 participants