Apply socket timeout to S3 CRT connections#7024
Merged
Merged
Conversation
Signed-off-by: jorgee <[email protected]>
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
bentsherman
reviewed
Apr 13, 2026
Signed-off-by: jorgee <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
bentsherman
approved these changes
Apr 15, 2026
jo-delia-faraguna
added a commit
to securebio/nao-mgs-workflow
that referenced
this pull request
May 6, 2026
Nextflow 26.04.0 (nextflow-io/nextflow#7024) repurposed this config key to also feed S3CrtConnectionHealthConfiguration.minimumThroughputTimeout, which the AWS SDK rejects when zero, aborting every S3 staging task with "minimumThroughputTimeout must be positive". 1 h preserves the previous "be patient with slow transfers" intent without the SDK validation error. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates how the
socket_timeoutconfiguration is handled for AWS S3 transfers using the CRT client in the SDK v2 integration. The main improvement is that whensocket_timeoutis set, it is now translated into a CRT connection health check, allowing the detection and closure of stalled S3 connections. The documentation and tests have also been updated to reflect this new behavior.AWS S3 CRT Client Timeout Handling:
socket_timeoutproperty for S3 transfers using the CRT client is now mapped to a connection health check that enforces a minimum throughput of 1 byte per second within the specified timeout period, instead of being ignored. This helps detect and close stalled CRT connections.Documentation Updates:
aws-java-sdk-v2.md) and configuration reference (config.md) have been updated to clarify the new behavior of theaws.client.socketTimeoutoption for CRT-based S3 transfers, including the lack of a default and the new health check mechanism. [1] [2]Testing Enhancements:
socket_timeoutis specified.Dependency and Import Adjustments:
S3CrtConnectionHealthConfigurationto support the new health check configuration.