Honor token field in BitbucketServerRepositoryProvider#7120
Conversation
Signed-off-by: jorgee <[email protected]>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
|
A few notes from a self-review pass: Important — bug in
|
|
Umm, new azure tests?! 😕 |
|
I haven't changed anything on azure in thia PR. @bentsherman, have you updated rnaseq-nf? |
Signed-off-by: Paolo Di Tommaso <[email protected]>
Summary
BitbucketServerRepositoryProviderpreviously inherited the defaultRepositoryProviderauth, which only readsuser/passwordand ignoredtoken. Configs supplying an HTTP access token hit BBS without an Authorization header (or with null Git credentials), producing 401 "Not authorized" at clone/branch lookup.hasCredentials,getAuth, andgetGitCredentialsso a token yieldsAuthorization: Bearer <token>for REST and is used as the password for Git over HTTPS.user+passwordstill works via Basic auth; when bothtokenandpasswordare set, the token wins (matchesBitbucketRepositoryProvider).NXF_BITBUCKET_SERVER_ACCESS_TOKENto use the setToken() instead of setAuth()Test plan
./gradlew :nextflow:test --tests "nextflow.scm.BitbucketServerRepositoryProviderTest"(23 tests, 0 failures, 3 skipped — env-gated integration tests)Verify end-to-end pipeline launch from Seqera Platform against a BBS repository configured with token-only credentials.
🤖 Generated with Claude Code