Fix docs CI on Python 3.14 by upgrading Sphinx#7175
Merged
Conversation
Sphinx 5.x imports the stdlib `imghdr` module, which was removed in Python 3.13 (PEP 594). After CI bumped to Python 3.14.5 the docs build fails on `import sphinx.builders.epub3`. Upgrade Sphinx and the companion packages that depend on it to versions that no longer rely on `imghdr`. Also trigger the Docs CI workflow when the workflow file itself is edited. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]> Signed-off-by: jorgee <[email protected]>
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
pditommaso
approved these changes
May 26, 2026
Member
|
I think we can probably just delete the docs CI now? We're not using Sphinx any more and I believe that @christopher-hakkaart will soon update the markdown contained in this repo to be compliant with Docusaurus, which will just break the CI again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
imghdrmodule, removed in Python 3.13 (PEP 594). After CI bumped to Python 3.14.5 the docs build fails onimport sphinx.builders.epub3→ModuleNotFoundError: No module named 'imghdr'.imghdr:myst-parser,sphinx-rtd-theme,sphinxcontrib-mermaid,sphinxext-rediraffe,sphinx-tabs..github/workflows/docs.yml) is edited —docs/**already coversdocs/requirements.txt.Test plan
imghdrfailure locally in a fresh Python 3.14 venv with the previous pins.pip install -r requirements.txt+make clean html) in a fresh Python 3.14 venv with the new pins — build succeeds.🤖 Generated with Claude Code