Thanks to visit codestin.com
Credit goes to github.com

Skip to content

add ngmaster module #1024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rpetit3 merged 7 commits into from
Nov 10, 2021
Merged

add ngmaster module #1024

rpetit3 merged 7 commits into from
Nov 10, 2021

Conversation

@rpetit3
Copy link
Contributor

@rpetit3 rpetit3 commented Nov 4, 2021 •
edited
Loading

PR checklist

Closes #1023

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd

@rpetit3 rpetit3 added the new module Adding a new module label Nov 4, 2021
@rpetit3 rpetit3 marked this pull request as draft November 4, 2021 04:35
@rpetit3
Copy link
Contributor Author

rpetit3 commented Nov 4, 2021

For some reason a Biocontainer is not available, trying to rebuild to see about get one made

bioconda/bioconda-recipes#31376

@rpetit3 rpetit3 mentioned this pull request Nov 4, 2021
Closed
80 tasks
@rpetit3 rpetit3 marked this pull request as ready for review November 4, 2021 17:43
@rpetit3
Copy link
Contributor Author

rpetit3 commented Nov 4, 2021

singularity image not created yet

grst
grst approved these changes Nov 6, 2021
View reviewed changes
Copy link
Member

@grst grst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@grst
Copy link
Member

grst commented Nov 6, 2021

Feel free to merge once the singularity test passes

@rpetit3
Copy link
Contributor Author

rpetit3 commented Nov 8, 2021

Still not available, I'll give it a few more days and reach out to Galaxy Project team to see if they can check it out.

@rpetit3
Copy link
Contributor Author

rpetit3 commented Nov 10, 2021

Good to go!

@rpetit3 rpetit3 merged commit 4bd5301 into nf-core:master Nov 10, 2021
@rpetit3 rpetit3 deleted the rp3-add-ngmaster branch November 10, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grst grst grst approved these changes

Assignees

No one assigned

Labels

new module Adding a new module Ready for Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

new module: ngmaster

2 participants

@rpetit3 @grst