Thanks to visit codestin.com
Credit goes to github.com

Skip to content

module for agrvate #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
abhi18av merged 16 commits into from
Sep 16, 2021
Merged

module for agrvate #693

abhi18av merged 16 commits into from
Sep 16, 2021

Conversation

@abhi18av
Copy link
Member

@abhi18av abhi18av commented Sep 8, 2021 •
edited
Loading

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the <SOFTWARE>.version.txt file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd

@abhi18av abhi18av mentioned this pull request Sep 8, 2021
Closed
80 tasks
@abhi18av abhi18av linked an issue Sep 8, 2021 that may be closed by this pull request
new module: agrvate #692
Closed
@abhi18av abhi18av marked this pull request as ready for review September 15, 2021 18:08
@abhi18av abhi18av marked this pull request as draft September 15, 2021 18:09
@abhi18av abhi18av marked this pull request as ready for review September 15, 2021 18:14
abhi18av
abhi18av commented Sep 15, 2021
View reviewed changes
@abhi18av abhi18av requested review from a team and rpetit3 September 15, 2021 18:16
rpetit3
rpetit3 reviewed Sep 15, 2021
View reviewed changes
@abhi18av abhi18av self-assigned this Sep 15, 2021
@abhi18av abhi18av added new module Adding a new module Ready for Review labels Sep 15, 2021
rpetit3
rpetit3 reviewed Sep 15, 2021
View reviewed changes
modules/agrvate/meta.yml Outdated
name: agrvate
description: write your description here
keywords:
- sort
Copy link
Contributor

@rpetit3 rpetit3 Sep 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

keywords:
    - fasta
    - virulence

Copy link
Member Author

@abhi18av abhi18av Sep 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpetit3 do you think that we should mention the Staphylococcus aureus as the keyword since this module is specifically focused on that species? 🤔

Copy link
Contributor

@rpetit3 rpetit3 Sep 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great question, I think yes because it will become helpful as more species-specific modules get added

rpetit3
rpetit3 reviewed Sep 15, 2021
View reviewed changes
rpetit3
rpetit3 reviewed Sep 15, 2021
View reviewed changes
@rpetit3
Copy link
Contributor

rpetit3 commented Sep 15, 2021

Looks good to me! Just minor suggestions

drpatelh
drpatelh reviewed Sep 16, 2021
View reviewed changes
drpatelh
drpatelh approved these changes Sep 16, 2021
View reviewed changes
Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too after incorporation @rpetit3 suggestions.

@abhi18av abhi18av merged commit 1840289 into nf-core:master Sep 16, 2021
@abhi18av
Copy link
Member Author

abhi18av commented Sep 16, 2021

@rpetit3 and @drpatelh - thanks for the feedback here!

@abhi18av abhi18av deleted the abhinav/agrvate branch September 16, 2021 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rpetit3 rpetit3 rpetit3 left review comments

@drpatelh drpatelh drpatelh approved these changes

Assignees

@abhi18av abhi18av

Labels

new module Adding a new module Ready for Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

new module: agrvate

3 participants

@abhi18av @rpetit3 @drpatelh