Thanks to visit codestin.com
Credit goes to github.com

Skip to content

add staphopia-sccmec module #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
drpatelh merged 6 commits into from
Sep 15, 2021
Merged

add staphopia-sccmec module #702

drpatelh merged 6 commits into from
Sep 15, 2021

Conversation

@rpetit3
Copy link
Contributor

@rpetit3 rpetit3 commented Sep 13, 2021 •
edited
Loading

PR checklist

Closes #701

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the <SOFTWARE>.version.txt file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd

@rpetit3 rpetit3 mentioned this pull request Sep 13, 2021
Closed
80 tasks
@rpetit3 rpetit3 added new module Adding a new module Ready for Review labels Sep 13, 2021
drpatelh
drpatelh approved these changes Sep 15, 2021
View reviewed changes
Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to say here! 🥇

@drpatelh drpatelh merged commit 073bbf1 into nf-core:master Sep 15, 2021
abhi18av pushed a commit to abhi18av/modules that referenced this pull request Sep 15, 2021
@rpetit3 @drpatelh @abhi18av
add staphopia-sccmec module (nf-core#702)
fb4a1e8 
* add staphopia-sccmec module

* add additional test

* change output name

* Update main.nf

* Update test.yml

Co-authored-by: Harshil Patel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drpatelh drpatelh drpatelh approved these changes

Assignees

No one assigned

Labels

new module Adding a new module Ready for Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

new module: staphopia-sccmec

2 participants

@rpetit3 @drpatelh