Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@rpetit3
Copy link
Contributor

@rpetit3 rpetit3 commented Oct 1, 2021

I goofed and reworked, which broke my ability to edit this PR #751

PR checklist

Closes #747

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd

So a few things

  1. I used TSVs from the bacass test-data.

  2. Should I even do the "extension guessing" or just always make it .csv? Currently it will give .tsv to TSV files

  3. CSVTK, allows you to use any input or output delimiter (e.g. ;, ,, \t, -, etc...). I need guidance on how we approach this (allow all our only , (csv) and \t (tsv).

This PR will probably be the framework for additional CSVTK sub-commands, so I'm OK with making changes. Thank you very much for you help!

Copy link
Member

@grst grst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove one obsolete line, then LGTM!

Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@drpatelh drpatelh merged commit 8179bab into nf-core:master Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

new module: csvtk/concat

3 participants