GitHub: Fix link to Contributing Guidelines #129
Conversation
db3721a to
0fcc38c
Compare
|
You can see the broken before state in #123 |
| Before creating a pull request, make sure to comply with | ||
| [`Contributing Guidelines`](/CONTRIBUTING.md). | ||
| Before creating a pull request, make sure to comply with the | ||
| [Contributing Guidelines](https://github.com/nginx/nginx/blob/master/CONTRIBUTING.md). |
There was a problem hiding this comment.
| [Contributing Guidelines](https://github.com/nginx/nginx/blob/master/CONTRIBUTING.md). | |
| [Contributing Guidelines](./CONTRIBUTING.md). |
a relative link would be better imo, so it always references the same revision when browsing older ones
There was a problem hiding this comment.
I agree, but will that work? GitHub seems really inconsistent with how it handles paths in Markdown links across different parts of the site.
(E.g., the rendered diff for this patch handles /CONTRIBUTING.md differently from how it handles it in PR bodies, as you can see in #123.)
I spot checked this against a few other major open source projects (nixpkgs, homebrew) and they all seem to use fully expanded URLs.
There was a problem hiding this comment.
You are correct, it does not. Sorry.
I didn't realize this was a pull request template.
I probably shouldn't review random PRs I stumble over while being tired 😅
There was a problem hiding this comment.
Thanks for the review either way! It's good to get this written down :)
Absolute paths in links end up being rooted at github.com. The contributing guidelines link is broken unless we use the full URL. Also, remove superfluous "monospace formatting" for the link.
Absolute paths in links end up being rooted at
github.com.The contributing guidelines link is broken unless we use the full URL.
Also, remove superfluous
monospace formattingfor the link.