Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@pluknet
Copy link
Contributor

@pluknet pluknet commented Sep 9, 2024

Proposed changes

WIP as obtained from https://mailman.nginx.org/pipermail/nginx-devel/2024-August/IKMUSKO6KA3UCDEJTXKDPZZZOEZ3THSO.html

The series adds object caching of statically specified certificates, certificate keys, CRLs, and CA ceritficates.

@pluknet pluknet force-pushed the ssl-cache branch 2 times, most recently from fc58084 to c51af6b Compare September 16, 2024 12:55
@pluknet
Copy link
Contributor Author

pluknet commented Sep 16, 2024

changes:

  • restored to always use the full name to avoid object duplicates and relative paths in logs
  • restored to support "data:" special value only for certificates/keys
  • removed using transient pool
  • removed duplicate string comparison for "data:" and "engine:" by caching this data in bit fields

@pluknet
Copy link
Contributor Author

pluknet commented Sep 19, 2024

changes:

  • restored ngx_ssl_certificate_name_index
  • misc.

@pluknet pluknet requested a review from arut September 19, 2024 14:32
Copy link
Member

@bavshin-f5 bavshin-f5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Instead of cross-linking the objects using exdata, pointers to configured
certificates are now stored in ngx_ssl_t, and OCSP staples are now accessed
with rbtree in it.  This allows sharing these objects between SSL contexts.

Based on previous work by Mini Hawthorne.
@pluknet
Copy link
Contributor Author

pluknet commented Sep 30, 2024

changes:

  • applied ngx_ssl_cache_fetch() simplification
  • added comment about ngx_ssl_cert_already_in_hash (requested by @arut in private), and some style

Copy link
Contributor

@arut arut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Added ngx_openssl_cache_module, which indexes a type-aware object cache.
It maps an id to a unique instance, and provides references to it, which
are dropped when the cycle's pool is destroyed.

The cache will be used in subsequent patches.

Based on previous work by Mini Hawthorne.
Certificate chains are now loaded once.

The certificate cache provides each chain as a unique stack of reference
counted elements.  This shallow copy is required because OpenSSL stacks
aren't reference counted.

Based on previous work by Mini Hawthorne.
EVP_KEY objects are a reference-counted container for key material, shallow
copies and OpenSSL stack management aren't needed as with certificates.

Based on previous work by Mini Hawthorne.
Based on previous work by Mini Hawthorne.
This can potentially provide a large amount of savings,
because CA certificates can be quite large.

Based on previous work by Mini Hawthorne.
@pluknet pluknet merged commit 5917e9d into nginx:master Oct 1, 2024
@pluknet pluknet deleted the ssl-cache branch October 1, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants