Proxy: proxy_pass_trailers directive. #153
Conversation
The directive allows to pass upstream response trailers to client.
|
|
||
| /* a whole header has been parsed successfully */ | ||
|
|
||
| buf->pos += len - (b->last - b->pos); |
There was a problem hiding this comment.
If trailers come in several buffers, (b->last - b->pos) can be larger than len. We need to subtract exactly the number of bytes processed during the current call.
There was a problem hiding this comment.
If I get you (and the code) right, you mean that b->last - b->pos may contain the result of copying several input buffers?
This should not happen though, because only a single input buffer is processed per call and ngx_http_parse_header_line() updates b->pos to b->last.
In other words,b->last == b->pos should be always true on a call entry after completing a previous call either with NGX_AGAIN or NGX_OK (considering several requests through a keepalive connection), and b should not contain remaining unprocessed data left from the previous call.
If you're about something else, please correct me.
The directive allows to pass upstream response trailers to client.