Adding missing files from recent pcre2 library #248
Conversation
|
Thanks for reporting this. This file was added recently. However we want to support old pcre2 versions as well. And there's another variable which should be used for files like this: |
|
@arut thanks for pointing this out. I fixed the PR to use the right variable. I tested locally and it just works. |
6a854dc to
f7f0c66
Compare
There was a problem hiding this comment.
The patch looks good.
The commit message needs to be adjusted, it lacks a proper prefix and a trailing dot.
Also, it doesn't mention the specific PCRE library version the change aims to fix building with, nor that it is specific to MSVC.
Something like this should work:
Configure: MSVC compatibility with PCRE2 10.43.
Please force-push with the updated commit log, then I will approve&merge.
f7f0c66 to
a1ffcb1
Compare
|
@pluknet thanks. Force-pushed. |
|
pcre2_convert.c was added in PCRE2 10.43, not 10.44, so please record exactly this version in the commit log. |
a1ffcb1 to
04d7528
Compare
|
@pluknet done. |
Proposed changes
I tried to build nginx on windows with msvc. Everything went relatively well except it failed to link because of a missing symbol.
That symbol is defined in a missing file from the list of pcre2 sources.