Thanks to visit codestin.com
Credit goes to github.com

Skip to content

TLS default protocol versions fixup. #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2024
Merged

TLS default protocol versions fixup. #327

merged 1 commit into from
Nov 22, 2024

Conversation

pluknet
Copy link
Contributor

@pluknet pluknet commented Nov 18, 2024

No description provided.

@pluknet
Copy link
Contributor Author

pluknet commented Nov 18, 2024

Squashed into a single commit per @arut request.

arut
arut reviewed Nov 20, 2024
View reviewed changes
Copy link
Contributor

@arut arut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks too emotional:

A previous attempt in ea15896 caused extra mess to handle MSVC deficiencies.

I think, we can safely reduce the amount of drama by something like

This simplifies merging protocol version after ea15896 and ebd18ec.

@pluknet
Copy link
Contributor Author

pluknet commented Nov 21, 2024

This looks too emotional:

A previous attempt in ea15896 caused extra mess to handle MSVC deficiencies.

Which part makes you think so?

The commit message pretty clear describes why ea15896 should be backed out and re-done is a more clean way.

I think, we can safely reduce the amount of drama by something like

"teh dramma" could be avoided at all if done with a proper review process.
It is unfortunate that I wasn't mentioned in the relevant PR.

@pluknet
SSL: a new macro to set default protocol versions.
d004a13 
This simplifies merging protocol values after ea15896 and ebd18ec.

Further, as outlined in ebd18ec, for libraries preceeding TLSv1.2+
support, only meaningful versions TLSv1 and TLSv1.1 are set by default.

While here, fixed indentation.
@pluknet
Copy link
Contributor Author

pluknet commented Nov 21, 2024

Changes:

  • addressed comments
  • set meaningful default for old libssl

@Maryna-f5 Maryna-f5 added this to the nginx-1.27.3 milestone Nov 21, 2024
arut
arut approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@arut arut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arut arut merged commit 476d652 into nginx:master Nov 22, 2024
1 check passed
@pluknet pluknet deleted the tls branch January 17, 2025 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arut arut arut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
nginx-1.27.3
Development

Successfully merging this pull request may close these issues.
3 participants
@pluknet @arut @Maryna-f5