Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Upstream: fix NGX_COMPAT build without NGX_HTTP_SSL after 454ad0e. #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

p-pautov
Copy link
Contributor

Fix "--with-compat" build, without "--with-http_ssl_module".

@pluknet
Copy link
Contributor

pluknet commented Jan 22, 2025

Upstream: fix NGX_COMPAT build without NGX_HTTP_SSL after 454ad0e.

Please update the synopsis to follow preceding commit logs.

I like to explicitly describe the combination of configure parameters that led to build failure,
to make a better visibility for those who might step on this.

This makes it to:

Upstream: fixed --with-compat build without SSL, broken by 454ad0e.

Or:

Upstream: fixed --with-compat build without SSL.

Broken by 454ad0e (not yet released).

I don't like the place where typedef is inserted,
this will further worsen typedef's prefix based grouping.

ngx_ssl_t and ngx_ssl_connection_t were originally located next to each other,
reflecting their struct declarations in ngx_event_openssl.h.

I'd try to place the new typedef somewhere next to them.

@p-pautov p-pautov force-pushed the dev/fix_compat_build branch from 220a02d to e55b4bf Compare January 22, 2025 18:37
@p-pautov p-pautov merged commit 5ab4f32 into nginx:master Jan 23, 2025
1 check passed
@p-pautov p-pautov deleted the dev/fix_compat_build branch January 23, 2025 18:50
@Maryna-f5 Maryna-f5 added this to the nginx-1.27.4 milestone Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants