First, a better solution would probably be this (see src/os/unix/ngx_posix_config.h):

#if (NGX_HAVE_CRYPT_H)                                                           
#include <crypt.h>                                                               
#endif

Further, are you having this issue on your system? If yes, could you please elaborate what kind of system that is. Unlike in the general POSIX case, this header is typically available in Linux distributions.

I believe this is the same issue as reported at
https://mailman.nginx.org/pipermail/nginx-devel/2024-February/U6NVHU7OSALXTJ65MTY2M5GNNWD7UA7U.html

Nice, I wasn't aware of it. Cherry-picked it now to replace my change.

Our use-case was FIPS compliance. We had to disable the use of crypt.h.

@orgads could you please revert completely to the original Piotr's patch?
I mean:

• the dot at the end of commit log subject line
• remove link to the email
• add empty lines above and beyond the include
• fix the email ("at" -> @)

I could do it myself and push the new (old) version to the branch, but it looks like you disabled this.

BTW, I tried this with musl (as mentioted by @PiotrSikora in the email thread) and indeed compilation breaks without the patch and works fine with it.

@orgads could you please revert completely to the original Piotr's patch? I mean:

• the dot at the end of commit log subject line
• remove link to the email
• add empty lines above and beyond the include
• fix the email ("at" -> @)

I could do it myself and push the new (old) version to the branch, but it looks like you disabled this.

Sure, done.

I didn't disable anything intentionally, maybe it's something in the repo settings or somewhere else.