Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add gitignore file. #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Add gitignore file. #518

merged 1 commit into from
Feb 20, 2025

Conversation

orgads
Copy link
Contributor

@orgads orgads commented Feb 13, 2025

No description provided.

Copy link
Member

@ac000 ac000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, yeah, indeed.

@pluknet
Copy link
Contributor

pluknet commented Feb 19, 2025

While I'm not a big fan of altering hg/git status output, because once you start doing this, you can no longer trust in the output, this particular change should not have a noticeable impact on existing muscle memory development patterns, so I'm rather ok with it.

Copy link
Contributor

@pluknet pluknet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least, the export target from misc/GNUmakefile needs to be updated.

@orgads
Copy link
Contributor Author

orgads commented Feb 19, 2025

Done, thanks.

@orgads orgads requested a review from pluknet February 19, 2025 12:38
@pluknet
Copy link
Contributor

pluknet commented Feb 19, 2025

What I meant is to exclude .gitignore from the resulting tarballs/zip.
It appears already excluded (by a trailing mask) though, no changes are needed here.

I'm fine regarding addition of "/tmp/":
it consists of intermediate files usually unused after building a release and somewhat unused when building changes. Anyway, underlying files are not intended for "git add".

I'm less confident regarding "/nginx-*.tar.gz":
it represents a rather moving part, also a corresponding zip entry would be missing, and finally, a person making release is assumed to be qualified to know what he is doing. Personally it's convenient to check files produced from "make release" with hg/git status.

To sum up, what I'd expect to see after sorting:

/Makefile
/objs/
/tmp/

@orgads
Copy link
Contributor Author

orgads commented Feb 19, 2025

Done, thank you.

Copy link
Contributor

@pluknet pluknet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections.

@arut
Copy link
Contributor

arut commented Feb 19, 2025

Also, a period at the end of the sentence please.

@orgads
Copy link
Contributor Author

orgads commented Feb 19, 2025

Done. I've never seen this notation used in other projects. Could you explain the reasoning behind it?

@orgads orgads changed the title Add gitignore file Add gitignore file. Feb 19, 2025
@arut
Copy link
Contributor

arut commented Feb 19, 2025

Done. I've never seen this notation used in other projects. Could you explain the reasoning behind it?

It's just a tradition. Since 2011 all nginx commit messages follow a certain format.

Copy link
Contributor

@arut arut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok for me too.

@ac000
Copy link
Member

ac000 commented Feb 19, 2025

Done. I've never seen this notation used in other projects. Could you explain the reasoning behind it?

It's just a tradition. Since 2011 all nginx commit messages follow a certain format.

We stopped doing that in Unit for the following reasons

  • It takes a up a valuable character
  • It's not generally a done thing in git commit subject lines (a few early Kernel & Git commits did do it...), one reason I guess is because they are often used as email subject lines, and both of these are not meant to be proper sentences and so do not require a terminating '.'
  • Can look messy. Update to version 1.0.1., Fix borkedness in foo.c.

@pluknet
Copy link
Contributor

pluknet commented Feb 20, 2025

@ac000
nginx have a well established code style and commit log style, please stick to it, thanks.

For more details, you can learn here: http://nginx.org/en/docs/contributing_changes.html

@arut arut merged commit f51e2de into nginx:master Feb 20, 2025
@orgads orgads deleted the gitignore branch February 20, 2025 11:46
@orgads
Copy link
Contributor Author

orgads commented Feb 20, 2025

@ac000 nginx have a well established code style and commit log style, please stick to it, thanks.

For more details, you can learn here: http://nginx.org/en/docs/contributing_changes.html

This guide doesn't mention anything about period.

@Maryna-f5 Maryna-f5 added this to the nginx-1.27.5 milestone Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants