-
Notifications
You must be signed in to change notification settings - Fork 7.3k
Add gitignore file. #518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gitignore file. #518
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heh, yeah, indeed.
While I'm not a big fan of altering hg/git status output, because once you start doing this, you can no longer trust in the output, this particular change should not have a noticeable impact on existing muscle memory development patterns, so I'm rather ok with it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least, the export target from misc/GNUmakefile needs to be updated.
Done, thanks. |
What I meant is to exclude .gitignore from the resulting tarballs/zip. I'm fine regarding addition of "/tmp/": I'm less confident regarding "/nginx-*.tar.gz": To sum up, what I'd expect to see after sorting:
|
Done, thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No objections.
Also, a period at the end of the sentence please. |
Done. I've never seen this notation used in other projects. Could you explain the reasoning behind it? |
It's just a tradition. Since 2011 all nginx commit messages follow a certain format. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok for me too.
We stopped doing that in Unit for the following reasons
|
@ac000 For more details, you can learn here: http://nginx.org/en/docs/contributing_changes.html |
This guide doesn't mention anything about period. |
No description provided.