Validate host #966
Open
Validate host #966
+339
−131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the request line is in the absolute-URI form, a host identified by a registered name (reg-name) is now restricted to start with an alphanumeric character (see RFC 1123, RFC 3986). Previously, empty domain labels or host starting with a hyphen were accepted. Additionally, host with a trailing dot is taken into account.
It is rewritten based on ngx_http_parse_request_line() state machine. This introduces several hardening changes: - host name with underscores is rejected - a port subcomponent is restricted to digits - for IP literals, a missing closing bracket and trailing dot are detected
Now that parsing of host in the absolute-URI form and as part of host header validation was equalized, this makes subsequent validation of host in absolute URIs unnecessary. No functional changes intended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series has some additional changes compared to previously posted on https://mailman.nginx.org/pipermail/nginx-devel/2024-June/KLY6JC27JZLSWBIOF6DT2FDDPIMDWWYK.html, most notably changes to stream, some minor though important fixes, rebase after c8c7beb and its proposed simplification via the ngx_http_validate_host() interface change.
See updated tests on my local branch:
https://github.com/pluknet/nginx-tests/tree/host