Fix: fallback to accept() when accept4() returns EINVAL on RedHat 9 #967
+15
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Thank you for your contribution! It appears you have not yet signed the F5 Contributor License Agreement (CLA), which is required for your changes to be incorporated into an F5 Open Source Software (OSS) project. Please kindly read the F5 CLA and reply on a new comment with the following text to agree: I have hereby read the F5 CLA and agree to its terms You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
|
I have hereby read the F5 CLA and agree to its terms |
|
Hi, Thanks for your contribution. However I doubt... AFAICT the only time you will get How often are you seeing this (if at all)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first open-source contribution
I added a compatibility fallback inside the ngx_event_accept() function (in src/event/ngx_event_accept.c)
to handle the case where accept4() fails with EINVAL (Invalid argument) on RedHat Enterprise Linux 9 systems.
This fix ensures that NGINX continues accepting connections gracefully by falling back to accept()
when accept4() is unsupported or behaves inconsistently with the SOCK_NONBLOCK flag.