SSL: changed interface of ngx_ssl_set_client_hello_callback(). #968
+26
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function interface is changed to use a standard approach of "ngx_int_t func(.., ngx_ssl_t *ssl, ..)" similar to other functions used to setup SSL_CTX, with the exception that "ngx_conf_t *cf" is omitted for simplicity as it is not bound to nginx configuration. This is required to properly handle and report SSL_CTX_set_ex_data() errors, as reminded by Coverity (CID 1668589).
|
@bavshin-f5 |
bavshin-f5
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function interface is changed to use a standard approach of "ngx_int_t func(.., ngx_ssl_t *ssl, ..)" similar to other functions used to setup SSL_CTX, with the exception that "ngx_conf_t *cf" is omitted for simplicity as it is not bound to nginx configuration.
This is required to properly handle and report SSL_CTX_set_ex_data() errors, as reminded by Coverity (CID 1668589).