Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@NicolasGensollen
Copy link
Member

Small PR fixing some scikit-learn deprecation warnings in a couple examples.
See scikit-learn/scikit-learn#17750 and scikit-learn/scikit-learn#17746

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2021

👋 @NicolasGensollen Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention "Closes #XXXX"
  • Code is PEP8-compliant.
  • (Bug fixes) There is at least one test that would fail under the original bug conditions.
  • (New features) There is at least one unit test per new function / class.
  • (New features) The new feature is demoed in at least one relevant example.

We will review it as quick as possible, feel free to ping us with questions if needed.

@NicolasGensollen NicolasGensollen self-assigned this Nov 5, 2021
@codecov
Copy link

codecov bot commented Nov 5, 2021

Codecov Report

Merging #3050 (1dbc71c) into main (6698244) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3050   +/-   ##
=======================================
  Coverage   90.11%   90.11%           
=======================================
  Files         106      106           
  Lines       14381    14381           
  Branches     2800     2800           
=======================================
  Hits        12959    12959           
  Misses        846      846           
  Partials      576      576           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6698244...1dbc71c. Read the comment docs.

Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx !

@NicolasGensollen
Copy link
Member Author

Thanks!
Merging...

@NicolasGensollen NicolasGensollen merged commit 1f4cf04 into nilearn:main Nov 7, 2021
@NicolasGensollen NicolasGensollen deleted the address-some-sklearn-deprecations branch November 7, 2021 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants