RF: os.path.abspath(x) -> os.path.join(runtime.cwd, x)#249
Merged
oesteban merged 3 commits intonipreps:masterfrom Jul 6, 2018
Merged
RF: os.path.abspath(x) -> os.path.join(runtime.cwd, x)#249oesteban merged 3 commits intonipreps:masterfrom
oesteban merged 3 commits intonipreps:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
runtimeis available, and we're creating a file in the working directory, the best practice is to useos.path.join(runtime.cwd, fname)overos.path.abspath(fname). This was established in nipy/nipype#2380, as some interfaces can fail on OSX due to whatever is going on with/varand/private/var.Ran into this with
EstimateReferenceImagewhile working on nipreps/fmriprep#1074.Not urgent, as I need ANTs anyway, and so have switched to working in Docker. There may be some other cases that can be moved; these were just the obvious ones.
Also removed a couple redundant calls to
os.path.abspath(fname)whenfnamewas defined withruntime.cwdalready.