Thanks to visit codestin.com
Credit goes to github.com

Skip to content

FIX: Revision of the B-Spline fitting code #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 4, 2024
Merged

FIX: Revision of the B-Spline fitting code #453

merged 5 commits into from
Jul 4, 2024

Conversation

@oesteban
Copy link
Member

@oesteban oesteban commented Jun 22, 2024

Several issues are addressed:

  • Fit intercept: instead of removing the mean/median/mode before fitting, let the model account for that by fitting an intercept.
  • Lower regularization alpha: it seems the regularization can be much lower when fitting only one level of b-splines
  • Update the workflow so only one level of b-splines is fit (multi-level fitting is not working, I believe)

@oesteban oesteban force-pushed the fix/revise-bspline-fitting branch from a54368d to 00519d3 Compare June 22, 2024 02:09
@oesteban oesteban requested a review from effigies June 22, 2024 02:09
@codecov
Copy link

codecov bot commented Jun 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.33%. Comparing base (bb89bdc) to head (1883c15).

Files Patch % Lines
sdcflows/workflows/fit/fieldmap.py 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #453      +/-   ##
==========================================
+ Coverage   76.21%   76.33%   +0.11%     
==========================================
  Files          32       32              
  Lines        2809     2814       +5     
  Branches      376      376              
==========================================
+ Hits         2141     2148       +7     
+ Misses        600      598       -2     
  Partials       68       68

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oesteban
Copy link
Member Author

oesteban commented Jul 4, 2024

This resolves Sunjae's dataset issue and brings all test back to green. Merging...

@oesteban oesteban merged commit 581e460 into master Jul 4, 2024
@oesteban oesteban deleted the fix/revise-bspline-fitting branch July 4, 2024 11:24
@effigies effigies mentioned this pull request Jul 10, 2024
Merged
effigies added a commit to nipreps/fmriprep that referenced this pull request Jul 10, 2024
@effigies
CI: Fix expected outputs for fieldmaps (#3321)
b04519f 
Following nipreps/sdcflows#453, we are no longer
storing multi-level coefficients for phasediff fieldmaps.
@effigies effigies mentioned this pull request Sep 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@effigies effigies Awaiting requested review from effigies

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oesteban