ENH: Dilate fmap and bold masks during coregistration #463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Sorry, but it's not clear to me why that test is failing. I guess it's this doctest? sdcflows/sdcflows/utils/wrangler.py Lines 107 to 113 in 1350d57 |
Member
|
Ah, it's global state and parallel tests interacting poorly. I'll figure out what's needed to isolate the state better. |
183a74f to
85e0197
Compare
effigies
approved these changes
Oct 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #463 +/- ##
==========================================
+ Coverage 83.66% 83.68% +0.01%
==========================================
Files 32 32
Lines 2816 2819 +3
Branches 377 377
==========================================
+ Hits 2356 2359 +3
Misses 390 390
Partials 70 70 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #461
The chosen radius (5 voxels) is a bit of a guess based on what has worked in the dataset where I was noticing failures. Input on a more systematic way to select this would be welcome.