Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@effigies
Copy link
Member

@effigies effigies commented May 15, 2025

Review pyproject.toml and check the commit list, but the full diff is not worth reviewing. There are no unsafe fixes and no manual fixes.

Another PR will follow with more.

Edit: Those are instructions if you want to review. I plan to merge this when tests pass unless stopped.

@effigies
Copy link
Member Author

I address the remaining style complaint with a small rewrite, so delaying to the next PR.

@codecov
Copy link

codecov bot commented May 15, 2025

Codecov Report

Attention: Patch coverage is 86.34294% with 90 lines in your changes missing coverage. Please review.

Project coverage is 84.09%. Comparing base (14df04c) to head (dc37060).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
sdcflows/config.py 54.54% 21 Missing and 4 partials ⚠️
sdcflows/cli/main.py 42.85% 10 Missing and 2 partials ⚠️
sdcflows/interfaces/bspline.py 86.15% 7 Missing and 2 partials ⚠️
sdcflows/cli/parser.py 38.46% 8 Missing ⚠️
sdcflows/workflows/fit/syn.py 86.88% 8 Missing ⚠️
sdcflows/interfaces/utils.py 86.79% 6 Missing and 1 partial ⚠️
sdcflows/cli/workflow.py 0.00% 6 Missing ⚠️
sdcflows/utils/wrangler.py 87.50% 3 Missing and 2 partials ⚠️
sdcflows/transform.py 90.90% 3 Missing ⚠️
sdcflows/workflows/fit/base.py 0.00% 3 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #492      +/-   ##
==========================================
+ Coverage   76.02%   84.09%   +8.06%     
==========================================
  Files          30       30              
  Lines        2870     2880      +10     
  Branches      374      374              
==========================================
+ Hits         2182     2422     +240     
+ Misses        618      384     -234     
- Partials       70       74       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@effigies effigies merged commit b4a01f6 into nipreps:main May 15, 2025
17 of 18 checks passed
@effigies effigies deleted the sty/ruff branch May 16, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant