FIX: Update SmoothEstimateOutputSpec resels description #3316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3316 +/- ##
==========================================
- Coverage 64.70% 64.70% -0.01%
==========================================
Files 302 302
Lines 39906 39906
Branches 5290 5290
==========================================
- Hits 25822 25821 -1
- Misses 12995 12997 +2
+ Partials 1089 1088 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
effigies
approved these changes
Mar 30, 2021
Co-authored-by: Chris Markiewicz <[email protected]>
|
Sounds good! |
|
Belatedly giving this a thumbs up. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As mentioned previously (poldracklab/ds003-post-fMRIPrep-analysis#7), the
reselsoutput of FSL's smoothest refers to the size of a resel, not the number of resels.List of changes proposed in this PR (pull-request)
I propose to update the output spec to avoid misunderstandings.
Acknowledgment