FIX: Make vendored LooseVersion comparable to distutils.version.LooseVersion #3466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
197ea62 to
aa99263
Compare
mgxd
approved these changes
May 11, 2022
| @pytest.mark.parametrize("v1, v2", [("0.0.0", "0.0.0"), ("0.0.0", "1.0.0")]) | ||
| def test_LooseVersion_compat(v1, v2): | ||
| vend1, vend2 = Vendored(v1), Vendored(v2) | ||
| orig1, orig2 = Original(v1), Original(v2) |
Member
There was a problem hiding this comment.
should we catch this DeprecationWarning warning that occurs when initializing a distutils Version?
Member
Author
There was a problem hiding this comment.
Do you get one? I don't in 3.10.
Member
There was a problem hiding this comment.
yeah, and i'm on 3.10.4...
DeprecationWarning: distutils Version classes are deprecated. Use packaging.version instead.
v = LooseVersion("0.0")
Member
Author
There was a problem hiding this comment.
Interesting. I'm on 3.10.4 and I don't see that. Does it happen just on the first one?
Member
There was a problem hiding this comment.
$ pytest nipype/external/tests/test_version.py
==================================================================== test session starts =====================================================================
platform darwin -- Python 3.10.4, pytest-7.1.1, pluggy-1.0.0
rootdir: /Users/mathiasg/code/nipype/nipype, configfile: pytest.ini
collected 2 items
nipype/external/tests/test_version.py .. [100%]
====================================================================== warnings summary ======================================================================
nipype/interfaces/io.py:1406
/Users/mathiasg/code/nipype/nipype/interfaces/io.py:1406: DeprecationWarning: invalid escape sequence '\w'
field_name = re.match("\w+", field_name).group()
nipype/interfaces/utility/base.py:232
/Users/mathiasg/code/nipype/nipype/interfaces/utility/base.py:232: DeprecationWarning: invalid escape sequence '\w'
"""Change the name of a file based on a mapped format string.
../../.pyenv/versions/3.10.4/envs/nipreps/lib/python3.10/site-packages/_pytest/config/__init__.py:1252
/Users/mathiasg/.pyenv/versions/3.10.4/envs/nipreps/lib/python3.10/site-packages/_pytest/config/__init__.py:1252: PytestConfigWarning: Unknown config option: env
self._warn_or_fail_if_strict(f"Unknown config option: {key}\n")
external/tests/test_version.py::test_LooseVersion_compat[0.0.0-0.0.0]
external/tests/test_version.py::test_LooseVersion_compat[0.0.0-0.0.0]
external/tests/test_version.py::test_LooseVersion_compat[0.0.0-1.0.0]
external/tests/test_version.py::test_LooseVersion_compat[0.0.0-1.0.0]
/Users/mathiasg/code/nipype/nipype/external/tests/test_version.py:18: DeprecationWarning: distutils Version classes are deprecated. Use packaging.version instead.
orig1, orig2 = Original(v1), Original(v2)
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
in any case, it's not a big deal
Member
Author
There was a problem hiding this comment.
Okay. I'll wrap it. Thanks for confirming.
Codecov Report
@@ Coverage Diff @@
## master #3466 +/- ##
=======================================
Coverage 65.25% 65.25%
=======================================
Files 309 309
Lines 40838 40838
Branches 5376 5376
=======================================
Hits 26647 26647
Misses 13117 13117
Partials 1074 1074
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out we need LooseVersions to be compatible with one another.