Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(dev): ensure socket path is accessable #1115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 28, 2023
Merged

fix(dev): ensure socket path is accessable #1115

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
508e6c4
fix: windows dev-Server returns 503
stpietsch Apr 5, 2023
3fc26b6
Merge branch 'main' into pr/sbittmann/1115
pi0 Jun 21, 2023
78740e9
Merge branch 'main' into pr/sbittmann/1115
pi0 Jun 28, 2023
47cc4a9
refactor: use accessSync and util
pi0 Jun 28, 2023
3b7b90d
set access error if no other errors
pi0 Jun 28, 2023
e74885f
suppress error for removing socket
pi0 Jun 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: use accessSync and util
  • Loading branch information
@pi0
pi0 committed Jun 28, 2023
commit 47cc4a9899af8dc0d1613c6e29112a7371baacc2
29 changes: 19 additions & 10 deletions src/dev/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { Worker } from "node:worker_threads";
import { existsSync, promises as fsp } from "node:fs";
import { existsSync, accessSync, promises as fsp } from "node:fs";
import { debounce } from "perfect-debounce";
import {
App,
Expand Down Expand Up @@ -186,18 +186,27 @@ export function createDevServer(nitro: Nitro): NitroDevServer {
proxyReq.setHeader("X-Forwarded-Proto", req.socket.remoteFamily);
}
});

const getWorkerAddress = () => {
const address = currentWorker?.address;
if (!address) {
return;
}
if (address.socketPath) {
try {
accessSync(address.socketPath);
} catch {
return;
}
}
return address;
};

app.use(
eventHandler(async (event) => {
await reloadPromise;
const address = currentWorker && currentWorker.address;
if (
!address ||
(address.socketPath &&
!(await fsp.access(address.socketPath).then(
() => true,
() => false
)))
) {
const address = getWorkerAddress();
if (!address) {
return errorHandler(lastError, event);
}
await proxy.handle(event, { target: address }).catch((err) => {
Expand Down