refactor(vite): use worker without wrapper for nitro env in dev #3466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3461
Classic nitro has a full-featured dev server entry with support for devHandlers. serving staticc assets, etc + a multi-worker manager, as with classic full-bundle rollup builds in dev, we need to swap workers to reload.
With vite plugin, we use it's runner RPC for HMR and also vite's dev server for dev middleware therefore we can also avoid using wrapper to simplify setup.
Some optional features have to be added back later to match prod features.