homebrew: allow setting greedy for all casks by default #1382
Conversation
| greedy = mkOption { | ||
| type = types.nullOr types.bool; |
There was a problem hiding this comment.
There’s also --greedy-latest and --greedy-auto-updates, maybe this should be an enum?
There was a problem hiding this comment.
AFAIK the options in this module are is just for Brewfile generation options, rather than being command-line parameters.
The only parameter I know that is possible to pass in regards to greediness of a cask is the boolean greedy: true option, so I would think it's better to not use an enum here and just stick to the boolean. I could be wrong about this tho.
There was a problem hiding this comment.
Looks like granularity options. Greedy would cover both latest and auto update, but you could choose either instead of both.
-g, --greedy
Also include outdated casks with auto_updates true or version :latest.
--greedy-latest
Also include outdated casks including those with version :latest.
--greedy-auto-updates
Also include outdated casks including those with auto_updates true.
There was a problem hiding this comment.
Yes, I know these are granularity options, but I'm fairly sure that these parameters have to be supported by brew-bundle's upstream first.
https://github.com/LnL7/nix-darwin/tree/master/modules/homebrew.nix#L55-L60 I found this in the current Homebrew module documentation, and then I looked through the brew-bundle source code for the cask spec at https://github.com/Homebrew/homebrew-bundle/blob/9fffe077f1a5a722ed5bd26a87ed622e8cb64e0c/spec/bundle/cask_installer_spec.rb. I don't see any way to enable passing --greedy-latest and --greedy-auto-updates without modifying this code.
I've also tried passing these arguments by constructing a Brewfile outside of Nix with the following contents:
cask "discord", greedy_latest: trueto no avail, unfortunately. The same happens with greedy_auto_updates.
Now I could be completely mistaken about how Brewfiles set the greedy_auto_updates or greedy_latest, but I'm not really sure about the whole thing tbh.
Specifying the
--greedyflag withbrew upgradefor each cask has to be done on an opt-in basis for each cask specified inhomebrew.casks, which can be rather tedious.This adds an option called
homebrew.greedyCasksthat sets the default value for thehomebrew.casks.*.greedyoption, so that all casks can be changed to be greedy at once, without needing to set that option for each cask. Opting out of--greedyby setting it tofalseper-cask when using this option is possible as well.Closes #572, #1201.