Convert non-configurable Zsh defaults into configurable options #1399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert the forced (and undocumented?) Zsh defaults into options.
|
Fixes #983. |
NOTE: this line needs to be in the PR description (not in a separate comment) to be considered by Github as a command to auto-close the linked issue when this PR is merged. |
Thanks. I've updated it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converts the following hard-coded options from /etc/zshrc into configurable options, but sets the previously hard-coded values as default.
The exception being that I changed the default
HISTFILEpath to"${ZDOTDIR:-$HOME}/.zsh_history"because that's what Apple sets by default.${ZDOTDIR:-$HOME}indicates that it will look forZDOTDIR, then revert to$HOME, if it doesn't find it.The new configurable options are:
programs.zsh = {defaultKeymaphistory.ignoreDupshistory.pathhistory.savehistory.sharehistory.size};Fixes #983.