fix: allow path to be used for dock's persistent-apps #1429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually for this I should add test case that uses path. Do not merge yet. |
|
In future you can set the PR to draft to indicate it's not ready to merge yet |
|
@Enzime I am not sure how to add a test case for paths while not being brittle to any minor changes to the test environment. Do you have any idea how to do that? I am not too sure about this though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1428
This use solution 1 in #1428.
Note that even if path is allowed due to purity checks only relative paths accessible by nix is allowed.
Conflicts with #1430