Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: add option programs.zsh.enableAutosuggestions #1433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add option programs.zsh.enableAutosuggestions #1433

wants to merge 1 commit into from

Conversation

ed9w2in6
Copy link

@ed9w2in6 ed9w2in6 commented May 1, 2025 •
edited
Loading

We got enableSyntaxHighlighting, so why not enableAutosuggestions too?

Ref: #527

I have added tests too.
However, I saw the other "plugin" related options for zsh are NOT tested.
Should I remove my tests for any reasons? e.g. resource concern

@ed9w2in6
feat: add option programs.zsh.enableAutosuggestions
0e83fc6 
We got enableSyntaxHighlighting, so why not enableAutosuggestions too?

Ref: nix-darwin#527
@ed9w2in6
Copy link
Author

ed9w2in6 commented May 1, 2025 •
edited
Loading

Personally, I am not using the likes of home-manager to manage my zsh configs for the moment.
I use some POSIX shell script to do that and it works well. (cross platform and shell!)

Without this option I have to awkwardly add pkgs.zsh-autosuggestions to packages via nix-darwin or home-manager then use some mechanism (e.g. environment.etc for nix-darwin or home.file for home-manager) to guarantee a stable path to be sourced.

This is a simple change and given we already added enableSyntaxHighlighting I think this similar feature is justified to be added.

@ed9w2in6
Copy link
Author

ed9w2in6 commented May 1, 2025 •
edited
Loading

However, if we aim for (semi-)compatibility with nixos, then we should create an issue to deprecate and remove all these options that does NOT exist on nixos.
ref: https://github.com/NixOS/nixpkgs/blob/383b5562858e3e8bda9d00b7756145813934f694/nixos/modules/programs/zsh/zsh.nix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ed9w2in6