Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: preactjs/preact-www#1240
tsconfig.json
, which were copied w/out accounting for the setbaseUrl
JSX
as a global type as this conflicts & clashes with all other JSX configurations. React recently stopped providing this as a global too.event.currentTarget
..target
is the original target of the event and can be any HTML element, requiring type casts..currentTarget
should be preferred in vanilla JS or any framework that uses native events (like Preact)..spellcheck
. While we support some of React's made up property cases, we're generally trying to cut back on that..spellcheck
is the native DOM casing and therefore the casing we support..spellCheck
will intentionally fail type checks, though at runtime it'll usually work (but it'll be set as an attribute, not as a property).Fixed Upstream:
auxclick
events: types: Add auxClick event types preactjs/preact#4672AriaAttributes
from compat: types: Expose AriaAttributes from compat preactjs/preact#4673EventHandler
from compat: types: Expose EventHandler from compat preactjs/preact#4674ForwardRefRenderFunction
: types: AddFowardRefRenderFunction
type to compat preactjs/preact#4675There's still a few type errors (excluding those which need a new Preact release, but that'll be in the next few days likely) that I don't quite know how to fix or if they're even Preact errors.