π Fix Docker build path in GitHub Actions and add .NET SDK container support #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Docker build in GitHub Actions was failing with:
Root cause: The workflow was running
docker build -t nlwebnet-demo:test .
from the repository root, but the Dockerfile is located atdeployment/docker/Dockerfile
.Solutions
π§ Primary Fix (Minimal Change)
Updated the GitHub Actions workflow to specify the correct Dockerfile path:
π Modern Alternative (.NET SDK Container Build)
Added support for .NET 9's built-in container capabilities as a modern alternative:
Benefits of .NET SDK approach:
π Enhanced Documentation
Investigation Results
The issue asked whether we still need a Dockerfile given .NET SDK container support. Both approaches have value:
Changes Made
.github/workflows/build.yml
: Fixed Docker build path + added .NET SDK container demosamples/Demo/NLWebNet.Demo.csproj
: Added container configuration propertiesdoc/deployment/README.md
: Updated with both containerization approachesTesting
β All 50 existing tests pass
β Docker command syntax verified
β No breaking changes introduced
Fixes #20.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
aka.ms
curl -I -sSL --retry 5 --retry-delay 2 --connect-timeout 15 REDACTED
(dns block)westus.data.mcr.microsoft.com
dotnet publish -c Release -p:PublishProfile=DefaultContainer
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
π¬ Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.