feat: add get trap to Proxy for agnostic prototype access#779
feat: add get trap to Proxy for agnostic prototype access#779markstos merged 4 commits intonode-config:masterfrom
get trap to Proxy for agnostic prototype access#779Conversation
get trap to Proxy for agnostic prototype access
|
Looks like an excellent approach with maximum immutability and minimal exceptions. Let's try it. |
|
Sweet! Thanks again, @markstos |
|
@jeremy-daley-kr I found there was a competing PR submitted to handle the binary type mangling: That PR returns a the binary object as a
Returning |
|
@markstos I might be a bit confused what the expected behavior is then, because this is the repo that was linked from @Maia-Everett original issue (#761), and it uses |
|
@markstos Also, I just checked out |
|
Since that's a new feature request/breaking change, can you consider publishing a new release in the meantime? |
|
@markstos Friendly bump ^^ |
|
@jdmarshall has been added as a co-maintainer to help move things along. We are evaluating plans for the next release now. Thanks for your patience with our volunteer team. |
Thanks, @markstos ! |
Changes
gettrap inutil.makeImmutablesProxyconfiginstanceofcheckingvowsscript so that individual test files can be runJSON.stringify