Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: handle bom in text and json #1482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 11, 2022
Merged

fix: handle bom in text and json #1482

merged 2 commits into from
Mar 11, 2022

Conversation

jimmywarting
Copy link
Collaborator

@jimmywarting jimmywarting commented Jan 25, 2022 •
edited by gr2m
Loading

Purpose

long over due problem to an easy fix... .text() & .json() didn't handle BOM correctly

Changes

switch buffer.toString() to TextDecoder().decode()

  • I added unit test(s)

@jimmywarting jimmywarting mentioned this pull request Mar 11, 2022
Closed
@jimmywarting jimmywarting requested review from gr2m and LinusU March 11, 2022 11:23
LinusU
LinusU approved these changes Mar 11, 2022
View reviewed changes
Copy link
Member

@LinusU LinusU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

@jimmywarting jimmywarting merged commit 6425e20 into node-fetch:main Mar 11, 2022
@jimmywarting jimmywarting deleted the bom branch March 11, 2022 21:49
@github-actions
Copy link

🎉 This PR is included in version 3.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@rhargreaves rhargreaves mentioned this pull request Mar 14, 2022
Open
@yashuatla yashuatla mentioned this pull request Jun 24, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr2m gr2m gr2m approved these changes

@LinusU LinusU LinusU approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handling a BOM with .json()
3 participants
@jimmywarting @gr2m @LinusU