Fix FetchError.errno type to match Node.js SystemError#1860
Open
veeceey wants to merge 1 commit intonode-fetch:mainfrom
Open
Fix FetchError.errno type to match Node.js SystemError#1860veeceey wants to merge 1 commit intonode-fetch:mainfrom
veeceey wants to merge 1 commit intonode-fetch:mainfrom
Conversation
Changes: - Updated TypeScript definition: errno?: string -> errno?: number - Added erroredSysCall property to match implementation - Fixed implementation to assign errno from systemError.errno instead of systemError.code - Updated tests to reflect correct errno type Fixes node-fetch#1831
Author
|
Friendly ping - any chance someone could take a look at this when they get a chance? Happy to make any changes if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the TypeScript type definition for
FetchError.errnoto properly match Node.jsSystemErrorspec, whereerrnois a number rather than a string.Changes
TypeScript definitions (
@types/index.d.ts):errno?: stringtoerrno?: numbererroredSysCall?: stringproperty (was missing but set in implementation)Implementation (
src/errors/fetch-error.js):errnofromsystemError.errno(number) instead of incorrectly usingsystemError.code(string)Tests (
test/main.js):errnoas a numberTesting
Ran full test suite - all existing tests pass (3 failures are pre-existing flaky network tests unrelated to this change).
Fixes #1831