Thanks to visit codestin.com
Credit goes to github.com

Skip to content

add cancel operation to editableList#4077

Merged
knolleary merged 1 commit into
node-red:devfrom
node-red-hitachi:support-editablelist-cnacel
Mar 2, 2023
Merged

add cancel operation to editableList#4077
knolleary merged 1 commit into
node-red:devfrom
node-red-hitachi:support-editablelist-cnacel

Conversation

@HiroyasuNishiyama

Copy link
Copy Markdown
Contributor
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

Node-RED beta-1 introduced locking flow feature.
However, this causes an issue in Node-RED Dashboards when changing the layout of widgets contained in a locked flow.

This PR is attempt to solve the issue. It requires moving of items in editableList to be cancelled. However, current editableList do not support it. So, this PR adds support of cancel operation to editableList.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage: 68.583% (+0.07%) from 68.51% when pulling 662b1a8 on node-red-hitachi:support-editablelist-cnacel into 910f613 on node-red:dev.

@knolleary knolleary merged commit 781eaf0 into node-red:dev Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants