Fix 108 #109
Fix 108 #109
Conversation
| var stats = []; | ||
| var total = list.length; | ||
| for (var i = 0; i < CONC; ++i) { | ||
| for (var i = 0; i < list.length && i < CONC; ++i) { |
There was a problem hiding this comment.
I'd consider a comparison with Math.min() more readable. Fans of premature optimization could save the min() result in a variable. ;-)
There was a problem hiding this comment.
Fine with me as long as its also done at the other places where this construction is used.
Anyhow it will change as the CONC construction is not working properly anyway for synchronous implementations . :-)
Verzonden van mijn HTC
----- Reply message -----
Van: "M.K." [email protected]
Aan: "sstur/nodeftpd" [email protected]
CC: "rianwouters" [email protected], "Author" [email protected]
Onderwerp: [sstur/nodeftpd] Fix 108 (#109)
Datum: vr, jun. 17, 2016 13:08
@@ -16,7 +16,7 @@ function statList(fsm, list, callback) {
var stats = [];
var total = list.length;
- for (var i = 0; i < CONC; ++i) {
- for (var i = 0; i < list.length && i < CONC; ++i) {
I'd consider a comparison with Math.min() more readable. Fans of premature optimization could save the min() result in a variable. ;-)
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/sstur/nodeftpd/pull/109/files/f90a4004d3b42385edd37998b8a8f178389914d4#r67494604
#108