Ensuring to forward the finish event from TLS socket #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reams will end properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sstur Hopefully it's self explanatory what's going on … the write stream requires the finish event to know that it needs to stop listening for chunks (and without it the upload hangs until timeout after sending all the data).
I didn't write any tests for it as it doesn't appear there are any for TLS (or even for the write streams generally?). Happy to contribute one if you feel this would make it easier to accept (though would probably take a bit of time as there's a lot of stubbing to do to get it to a stage where a test would work).